Skip to content

[doc]Fix gradient accumulation doc.#4349

Merged
ver217 merged 2 commits intohpcaitech:mainfrom
flybird11111:fix-doc
Aug 4, 2023
Merged

[doc]Fix gradient accumulation doc.#4349
ver217 merged 2 commits intohpcaitech:mainfrom
flybird11111:fix-doc

Conversation

@flybird11111
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

The gradients are summed instead of being averaged.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@flybird11111 flybird11111 requested review from oahzxl and ver217 July 28, 2023 09:33
@ver217 ver217 merged commit f40b718 into hpcaitech:main Aug 4, 2023
@flybird11111 flybird11111 deleted the fix-doc branch April 11, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants