Skip to content

[test] remove useless tests#4359

Merged
ver217 merged 3 commits intohpcaitech:mainfrom
ver217:test/remove-useless
Aug 1, 2023
Merged

[test] remove useless tests#4359
ver217 merged 3 commits intohpcaitech:mainfrom
ver217:test/remove-useless

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Aug 1, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

NA

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

I analyzed the time duration and found some outdated tests take extremly long time.

image

  1. Code of legacy zero won't be updated and will be removed soon. We don't need to test it.
  2. Outdated checkpoint io is not needed.
  3. Lazy init distributed method is not used and we can remove it in the future.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the testing related to our testing label Aug 1, 2023
@ver217 ver217 requested a review from FrankLeeeee August 1, 2023 08:45
@ver217 ver217 merged commit 16bf4c0 into hpcaitech:main Aug 1, 2023
@ver217 ver217 deleted the test/remove-useless branch August 1, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing related to our testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants