Skip to content

[gemini] fix tensor storage cleaning in state dict collection #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ver217 merged 1 commit into from
Aug 10, 2023
Merged

[gemini] fix tensor storage cleaning in state dict collection #4396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions colossalai/zero/gemini/gemini_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# this code is inspired by the DeepSpeed library and implemented with our own design from scratch
import copy
import gc
import math
import warnings
from typing import Any, Dict, Iterator, OrderedDict, Set, Tuple
Expand Down Expand Up @@ -468,11 +467,6 @@ def collect_states(self, param_id: int, only_rank_0: bool = True) -> dict:
self.load_from_compacted_states(compacted_states, collected_states, state_names, shard_offset,
shard_size)

# Clean gathered states
for state_shard in gathered_state_shards:
del state_shard[0]
gc.collect()

# Reshape tensors
if is_collector:
for state_name, state_tensor in collected_states.items():
Expand Down