[shardformer] Support customized policy for llamav2 based model with HybridParallelPlugin#4614
Closed
eric8607242 wants to merge 3 commits intohpcaitech:feature/shardformerfrom
Closed
[shardformer] Support customized policy for llamav2 based model with HybridParallelPlugin#4614eric8607242 wants to merge 3 commits intohpcaitech:feature/shardformerfrom
eric8607242 wants to merge 3 commits intohpcaitech:feature/shardformerfrom
Conversation
flybird11111
suggested changes
Sep 5, 2023
| class HybridParallelModule(ModelWrapper): | ||
|
|
||
| def __init__(self, module: Module, precision: str, shard_config: ShardConfig, dp_group: ProcessGroup, use_ddp: bool, | ||
| ddp_config: dict) -> None: |
Contributor
There was a problem hiding this comment.
Thank you for your contribution. Could you please make some changes here? It's best not to expose 'Policy' in the plugin; it's just a component of Shardformer.
Contributor
Author
There was a problem hiding this comment.
Hi,
Thanks for your review!
I have two candidate approaches currently.
- Remove the typing hint
- Modify the typing hint from Policy to Object
Which one do you think better?
Contributor
Author
There was a problem hiding this comment.
Hi,
I modify the code with the second approach (modify from Policy to object)
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
#4613
📝 What does this PR do?
In this PR, I have two modifications for
ShardFormer.policyforHybridParallelPlugin, which enables user can applyHybridParallelto their own model with customizedPolicy.self_attn.num_key_value_headsforLlamaPolicy. The attribute is new for LLaMAv2, without this attribute replacement, I can not apply tensor parallelism on LLaMAv2 successfully.💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.