Skip to content

[moe]: modify router loss, polish code#4693

Merged
cwher merged 5 commits intohpcaitech:feature/moefrom
cwher:close-moe
Sep 13, 2023
Merged

[moe]: modify router loss, polish code#4693
cwher merged 5 commits intohpcaitech:feature/moefrom
cwher:close-moe

Conversation

@cwher
Copy link
Copy Markdown
Contributor

@cwher cwher commented Sep 12, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@cwher cwher requested a review from oahzxl September 12, 2023 07:41
@cwher cwher merged commit 2241a37 into hpcaitech:feature/moe Sep 13, 2023
oahzxl pushed a commit to oahzxl/ColossalAI that referenced this pull request Sep 15, 2023
* feat: check z_loss and add doc

* style: rename misleading variable

* feat: modify auxiliary loss

* feat: add aux_loss in topk router and modify doc

* docs: add fn doc
oahzxl pushed a commit to oahzxl/ColossalAI that referenced this pull request Sep 15, 2023
* feat: check z_loss and add doc

* style: rename misleading variable

* feat: modify auxiliary loss

* feat: add aux_loss in topk router and modify doc

* docs: add fn doc
oahzxl pushed a commit to oahzxl/ColossalAI that referenced this pull request Oct 26, 2023
* feat: check z_loss and add doc

* style: rename misleading variable

* feat: modify auxiliary loss

* feat: add aux_loss in topk router and modify doc

* docs: add fn doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants