Skip to content

[pipeline inference] Fix the blocking of communication when ppsize is 2#4708

Merged
FoolPlayer merged 6 commits intohpcaitech:feature/pipeline-inferfrom
FoolPlayer:fix/ppinfer
Sep 21, 2023
Merged

[pipeline inference] Fix the blocking of communication when ppsize is 2#4708
FoolPlayer merged 6 commits intohpcaitech:feature/pipeline-inferfrom
FoolPlayer:fix/ppinfer

Conversation

@FoolPlayer
Copy link
Copy Markdown
Contributor

@FoolPlayer FoolPlayer commented Sep 13, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FoolPlayer FoolPlayer changed the title [pipeline inference] Fix the blocking of communication when ppsize > 2 [pipeline inference] Fix the blocking of communication when ppsize = 2 Sep 13, 2023
@FoolPlayer FoolPlayer changed the title [pipeline inference] Fix the blocking of communication when ppsize = 2 [pipeline inference] Fix the blocking of communication when ppsize is 2 Sep 13, 2023
ver217
ver217 reviewed Sep 18, 2023
View reviewed changes
Comment thread colossalai/pipeline/schedule/generate.py
@FoolPlayer FoolPlayer merged commit 09fc284 into hpcaitech:feature/pipeline-infer Sep 21, 2023
@FoolPlayer FoolPlayer deleted the fix/ppinfer branch September 21, 2023 08:25
FoolPlayer added a commit that referenced this pull request Sep 27, 2023
@FoolPlayer
[pipeline inference] Fix the blocking of communication when ppsize is…
65d300f 
… 2 (#4708)

* add benchmark verbose

* fix export tokens

* fix benchmark verbose

* add P2POp style to do p2p communication

* modify schedule as p2p type when ppsize is 2

* remove unused code and add docstring
FoolPlayer added a commit that referenced this pull request Oct 11, 2023
@FoolPlayer
[Pipeline Inference] Sync pipeline inference branch to main (#4820)
08a9f76 
* [pipeline inference] pipeline inference (#4492)

* add pp stage manager as circle stage

* fix a bug when create process group

* add ppinfer basic framework

* add micro batch manager and support kvcache-pp gpt2 fwd

* add generate schedule

* use mb size to control mb number

* support generate with kv cache

* add output, remove unused code

* add test

* reuse shardformer to build model

* refactor some code and use the same attribute name of hf

* fix review and add test for generation

* remove unused file

* fix CI

* add cache clear

* fix code error

* fix typo

* [Pipeline inference] Modify to tieweight (#4599)

* add pp stage manager as circle stage

* fix a bug when create process group

* add ppinfer basic framework

* add micro batch manager and support kvcache-pp gpt2 fwd

* add generate schedule

* use mb size to control mb number

* support generate with kv cache

* add output, remove unused code

* add test

* reuse shardformer to build model

* refactor some code and use the same attribute name of hf

* fix review and add test for generation

* remove unused file

* modify the way of saving newtokens

* modify to tieweight

* modify test

* remove unused file

* solve review

* add docstring

* [Pipeline inference] support llama pipeline inference (#4647)

* support llama pipeline inference

* remove tie weight operation

* [pipeline inference] Fix the blocking of communication when ppsize is 2 (#4708)

* add benchmark verbose

* fix export tokens

* fix benchmark verbose

* add P2POp style to do p2p communication

* modify schedule as p2p type when ppsize is 2

* remove unused code and add docstring

* [Pipeline inference] Refactor code, add docsting, fix bug (#4790)

* add benchmark script

* update argparse

* fix fp16 load

* refactor code style

* add docstring

* polish code

* fix test bug

* [Pipeline inference] Add pipeline inference docs (#4817)

* add readme doc

* add a ico

* Add performance

* update table of contents

* refactor code (#4873)
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Oct 18, 2023
@FoolPlayer @flybird11111
[Pipeline Inference] Sync pipeline inference branch to main (hpcaitec…
e0a8908 
…h#4820)

* [pipeline inference] pipeline inference (hpcaitech#4492)

* add pp stage manager as circle stage

* fix a bug when create process group

* add ppinfer basic framework

* add micro batch manager and support kvcache-pp gpt2 fwd

* add generate schedule

* use mb size to control mb number

* support generate with kv cache

* add output, remove unused code

* add test

* reuse shardformer to build model

* refactor some code and use the same attribute name of hf

* fix review and add test for generation

* remove unused file

* fix CI

* add cache clear

* fix code error

* fix typo

* [Pipeline inference] Modify to tieweight (hpcaitech#4599)

* add pp stage manager as circle stage

* fix a bug when create process group

* add ppinfer basic framework

* add micro batch manager and support kvcache-pp gpt2 fwd

* add generate schedule

* use mb size to control mb number

* support generate with kv cache

* add output, remove unused code

* add test

* reuse shardformer to build model

* refactor some code and use the same attribute name of hf

* fix review and add test for generation

* remove unused file

* modify the way of saving newtokens

* modify to tieweight

* modify test

* remove unused file

* solve review

* add docstring

* [Pipeline inference] support llama pipeline inference (hpcaitech#4647)

* support llama pipeline inference

* remove tie weight operation

* [pipeline inference] Fix the blocking of communication when ppsize is 2 (hpcaitech#4708)

* add benchmark verbose

* fix export tokens

* fix benchmark verbose

* add P2POp style to do p2p communication

* modify schedule as p2p type when ppsize is 2

* remove unused code and add docstring

* [Pipeline inference] Refactor code, add docsting, fix bug (hpcaitech#4790)

* add benchmark script

* update argparse

* fix fp16 load

* refactor code style

* add docstring

* polish code

* fix test bug

* [Pipeline inference] Add pipeline inference docs (hpcaitech#4817)

* add readme doc

* add a ico

* Add performance

* update table of contents

* refactor code (hpcaitech#4873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ver217 ver217 ver217 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FoolPlayer @ver217