Skip to content

[inference]fix import bug and delete down useless init#4830

Merged
Xu-Kai merged 4 commits intohpcaitech:mainfrom
CjhHa1:fix_infer
Oct 4, 2023
Merged

[inference]fix import bug and delete down useless init#4830
Xu-Kai merged 4 commits intohpcaitech:mainfrom
CjhHa1:fix_infer

Conversation

@CjhHa1
Copy link
Copy Markdown
Contributor

@CjhHa1 CjhHa1 commented Sep 28, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.
This PR fix the import bugs and delete useless inits

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@CjhHa1 CjhHa1 requested review from Xu-Kai and tiandiao123 and removed request for Xu-Kai September 28, 2023 06:26
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 11%.

Click me to view the complete report
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
colossalai/inference/tensor_parallel/modeling/__init__.py       4      4     0%
colossalai/inference/tensor_parallel/modeling/_utils.py        36     36     0%
colossalai/inference/tensor_parallel/modeling/llama.py        155    155     0%
colossalai/inference/tensor_parallel/policies/chatglm2.py      43     43     0%
colossalai/inference/tensor_parallel/policies/llama.py         49     49     0%
colossalai/kernel/triton/__init__.py                           16      3    81%
tests/test_infer/test_llama_infer.py                           40     15    62%
-------------------------------------------------------------------------------
TOTAL                                                         343    305    11%

@CjhHa1 CjhHa1 requested a review from isky-cd September 28, 2023 09:51
Copy link
Copy Markdown
Contributor

@yuanheng-zhao yuanheng-zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LLAMA benchmark works as usual

Comment thread colossalai/inference/tensor_parallel/modeling/_utils.py Outdated
Comment thread colossalai/inference/tensor_parallel/modeling/_utils.py
Comment thread colossalai/inference/tensor_parallel/modeling/_utils.py Outdated
Comment thread colossalai/inference/tensor_parallel/modeling/llama.py
Comment thread colossalai/inference/tensor_parallel/modeling/_utils.py
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

The code coverage for the changed files is 11%.

Click me to view the complete report
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
colossalai/inference/tensor_parallel/modeling/__init__.py       4      4     0%
colossalai/inference/tensor_parallel/modeling/_utils.py        33     33     0%
colossalai/inference/tensor_parallel/modeling/llama.py        155    155     0%
colossalai/inference/tensor_parallel/policies/chatglm2.py      43     43     0%
colossalai/inference/tensor_parallel/policies/llama.py         49     49     0%
colossalai/kernel/triton/__init__.py                           16      3    81%
tests/test_infer/test_llama_infer.py                           40     15    62%
-------------------------------------------------------------------------------
TOTAL                                                         340    302    11%

@Xu-Kai Xu-Kai merged commit 013a4be into hpcaitech:main Oct 4, 2023
@CjhHa1 CjhHa1 deleted the fix_infer branch October 7, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants