Skip to content

[hotfix] fix bug in sequence parallel test#4887

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
littsk:hotfix/sequence_parallal_test
Oct 11, 2023
Merged

[hotfix] fix bug in sequence parallel test#4887
ver217 merged 1 commit intohpcaitech:mainfrom
littsk:hotfix/sequence_parallal_test

Conversation

@littsk
Copy link
Copy Markdown
Contributor

@littsk littsk commented Oct 11, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed #4888

📝 What does this PR do?

When enabling sequence parallelism during testing, the test fails. This pull request aims to address and rectify this issue.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 merged commit ffd9a3c into hpcaitech:main Oct 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 66%.

Click me to view the complete report
Name                                          Stmts   Miss  Cover
-----------------------------------------------------------------
tests/test_shardformer/test_model/_utils.py     182     62    66%
-----------------------------------------------------------------
TOTAL                                           182     62    66%

flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: sequence parallel test failed

3 participants