Skip to content

[doc] add reminder for issue encountered with hybrid adam#4889

Merged
ppt0011 merged 1 commit intohpcaitech:mainfrom
ppt0011:main
Oct 12, 2023
Merged

[doc] add reminder for issue encountered with hybrid adam#4889
ppt0011 merged 1 commit intohpcaitech:mainfrom
ppt0011:main

Conversation

@ppt0011
Copy link
Copy Markdown
Contributor

@ppt0011 ppt0011 commented Oct 11, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ppt0011 ppt0011 requested review from FrankLeeeee and ver217 October 11, 2023 09:52
Copy link
Copy Markdown
Contributor

@CjhHa1 CjhHa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppt0011 ppt0011 merged commit c1fab95 into hpcaitech:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants