Skip to content

[lora] add lora APIs for booster, support lora for TorchDDP#4981

Merged
Fridge003 merged 11 commits intohpcaitech:feature/lorafrom
Fridge003:feature/lora
Oct 31, 2023
Merged

[lora] add lora APIs for booster, support lora for TorchDDP#4981
Fridge003 merged 11 commits intohpcaitech:feature/lorafrom
Fridge003:feature/lora

Conversation

@Fridge003
Copy link
Copy Markdown
Contributor

@Fridge003 Fridge003 commented Oct 26, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Implement basic Lora features for booster APIs; Support Lora for TorchDDP Plugin and add relevant tests.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Fridge003 Fridge003 requested a review from ver217 October 26, 2023 09:23
@Fridge003 Fridge003 merged commit c5fd4aa into hpcaitech:feature/lora Oct 31, 2023
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Dec 21, 2023
@flybird11111
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
76ecb90 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Mar 13, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
1da965b 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Apr 7, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
582ea51 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Apr 7, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
db92c79 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Apr 17, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
b8b6239 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Apr 22, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
8019d1d 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Apr 23, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
0eb9a57 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
linsj20 pushed a commit to linsj20/ColossalAI that referenced this pull request Apr 23, 2024
@linsj20
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
c1fa707 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Apr 26, 2024
@ver217
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
5613e93 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
ver217 pushed a commit that referenced this pull request Apr 28, 2024
@ver217
[lora] add lora APIs for booster, support lora for TorchDDP (#4981)
14b0d4c 
* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
wangbluo pushed a commit to wangbluo/ColossalAI that referenced this pull request May 7, 2024
@wangbluo
[lora] add lora APIs for booster, support lora for TorchDDP (hpcaitec…
55edb27 
…h#4981)

* add apis and peft requirement

* add liscense and implement apis

* add checkpointio apis

* add torchddp fwd_bwd test

* add support_lora methods

* add checkpointio test and debug

* delete unneeded codes

* remove peft from LICENSE

* add concrete methods for enable_lora

* simplify enable_lora api

* fix requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ver217 ver217 ver217 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fridge003 @ver217