Skip to content

[gemini]fix gemini optimzer, saving Shardformer in Gemini got list assignment index out of range #5085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ver217 merged 1 commit into from
Nov 22, 2023
Merged

[gemini]fix gemini optimzer, saving Shardformer in Gemini got list assignment index out of range #5085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions colossalai/zero/gemini/gemini_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,18 +425,18 @@ def collect_states(self, param_id: int, only_rank_0: bool = True) -> dict:
param = self.id_to_real_params[param_id]
fake_param = self.id_to_fake_params.get(param_id, None)
chunk = self.chunk_manager.get_chunk(param)
dp_group = chunk.torch_pg
rank = dist.get_rank(dp_group)
zero_group = chunk.torch_pg
rank = dist.get_rank(zero_group)
master_rank = 0
collected_states = {}

# Fetch names of states through all_gather.
local_state_names = None
if fake_param is not None:
local_state_names = list(self.optim.state[fake_param].keys())
gathered_state_names = [None for _ in range(dist.get_world_size(dp_group))]
gathered_state_names = [None for _ in range(dist.get_world_size(zero_group))]
dist.barrier()
dist.all_gather_object(gathered_state_names, local_state_names, dp_group)
dist.all_gather_object(gathered_state_names, local_state_names, zero_group)
state_names = None
for names in gathered_state_names:
if names is not None:
Expand Down Expand Up @@ -510,10 +510,10 @@ def collect_states(self, param_id: int, only_rank_0: bool = True) -> dict:
_, shard_offset, shard_size = self.get_offsets(param_id)

# Collectors gather state shards through all_gathering.
gathered_state_shards = [None for _ in range(dist.get_world_size(dp_group))]
gathered_state_shards = [None for _ in range(dist.get_world_size(zero_group))]

dist.barrier()
dist.all_gather_object(gathered_state_shards, [compacted_states, shard_offset, shard_size])
dist.all_gather_object(gathered_state_shards, [compacted_states, shard_offset, shard_size], group=zero_group)

if is_collector:
for state_shard in gathered_state_shards:
Expand Down