Skip to content

[ColossalChat][WIP] Refactor coati; Fix PPO, LORA; Add DPO #5148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YeAnbang wants to merge 23 commits into from
Closed

[ColossalChat][WIP] Refactor coati; Fix PPO, LORA; Add DPO #5148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7d77917
Add dpo. Fix sft, ppo, lora. Refactor all
YeAnbang Nov 21, 2023
cc69b6d
fix and tested ppo
YeAnbang Nov 30, 2023
b50b49f
2 nd round refactor
YeAnbang Nov 30, 2023
477fe27
add ci tests
YeAnbang Dec 1, 2023
f613193
fix ci
YeAnbang Dec 4, 2023
0d542d6
fix ci
YeAnbang Dec 5, 2023
c268100
fix readme, style
YeAnbang Dec 6, 2023
63c64fc
fix readme style
YeAnbang Dec 6, 2023
c29a656
fix style, fix benchmark
YeAnbang Dec 6, 2023
143bb94
reproduce benchmark result, remove useless files
YeAnbang Dec 7, 2023
427f161
rename to ColossalChat
YeAnbang Dec 7, 2023
b0ac968
use new image
YeAnbang Dec 8, 2023
853642c
fix ci workflow
YeAnbang Dec 11, 2023
4489602
fix ci
YeAnbang Dec 11, 2023
d88e2d9
use local model/tokenizer for ci tests
YeAnbang Dec 12, 2023
d48c4ac
fix ci
YeAnbang Dec 12, 2023
b6f4d85
fix ci
YeAnbang Dec 12, 2023
7f5aae5
fix ci
YeAnbang Dec 13, 2023
185b3b0
fix ci timeout
YeAnbang Dec 13, 2023
cfb6f67
fix rm progress bar. fix ci timeout
YeAnbang Dec 13, 2023
f9e151e
fix ci
YeAnbang Dec 14, 2023
9b62c0e
fix ci typo
YeAnbang Dec 14, 2023
9bc0d42
remove 3d plugin from ci temporary
YeAnbang Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_on_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
github.event.repository.full_name == 'hpcaitech/ColossalAI'
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --rm
timeout-minutes: 5
defaults:
Expand All @@ -54,7 +54,7 @@ jobs:
github.event.pull_request.base.repo.full_name == 'hpcaitech/ColossalAI'
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --rm
timeout-minutes: 5
defaults:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_on_schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
if: github.repository == 'hpcaitech/ColossalAI'
runs-on: [self-hosted, 8-gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm -v /data/scratch/cifar-10:/data/scratch/cifar-10 -v /data/scratch/llama-tiny:/data/scratch/llama-tiny
timeout-minutes: 40
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/doc_test_on_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
needs: detect-changed-doc
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm
timeout-minutes: 20
defaults:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/doc_test_on_schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Test the changed Doc
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm
timeout-minutes: 60
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example_check_on_dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
fail-fast: false
matrix: ${{fromJson(needs.manual_check_matrix_preparation.outputs.matrix)}}
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm -v /data/scratch/examples-data:/data/
timeout-minutes: 10
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example_check_on_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
fail-fast: false
matrix: ${{fromJson(needs.detect-changed-example.outputs.matrix)}}
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm -v /data/scratch/examples-data:/data/
timeout-minutes: 20
concurrency:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example_check_on_schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
fail-fast: false
matrix: ${{fromJson(needs.matrix_preparation.outputs.matrix)}}
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
timeout-minutes: 10
steps:
- name: 📚 Checkout
Expand Down
21 changes: 11 additions & 10 deletions .github/workflows/run_chatgpt_examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
github.event.pull_request.base.repo.full_name == 'hpcaitech/ColossalAI'
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
options: --gpus all --rm -v /data/scratch/github_actions/chat:/data/scratch/github_actions/chat --shm-size=10.24gb
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm -v /data/scratch/colossal-llama2:/data/scratch/colossal-llama2 --shm-size=10.24gb
timeout-minutes: 30
defaults:
run:
Expand All @@ -30,24 +30,25 @@ jobs:

- name: Install ChatGPT
run: |
cd applications/Chat
cd applications/ColossalChat
pip install -v .
pip install -r examples/requirements.txt

- name: Install Transformers
run: |
pip install transformers==4.30.2
pip install transformers==4.32.1

- name: Execute Examples
run: |
cd applications/Chat
cd applications/ColossalChat
rm -rf ~/.cache/colossalai
./tests/test_inference.sh
./tests/test_benchmarks.sh
./tests/test_data_preparation.sh
./tests/test_train.sh
env:
NCCL_SHM_DISABLE: 1
MAX_JOBS: 8
SFT_DATASET: /data/scratch/github_actions/chat/data.json
PROMPT_DATASET: /data/scratch/github_actions/chat/prompts_en.jsonl
PRETRAIN_DATASET: /data/scratch/github_actions/chat/alpaca_data.json
PRETRAINED_MODEL_PATH: /data/scratch/colossal-llama2/models
SFT_DATASET: /data/scratch/colossal-llama2/colossal_chat_test_data/sft
PROMPT_DATASET: /data/scratch/colossal-llama2/colossal_chat_test_data/prompt
PRETRAIN_DATASET: /data/scratch/colossal-llama2/colossal_chat_test_data/ptx
PREFERENCE_DATASET: /data/scratch/colossal-llama2/colossal_chat_test_data/preference
9 changes: 5 additions & 4 deletions .github/workflows/run_chatgpt_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
github.event.pull_request.base.repo.full_name == 'hpcaitech/ColossalAI'
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
options: --gpus all --rm -v /data/scratch/chatgpt:/data/scratch/chatgpt
timeout-minutes: 30
defaults:
Expand All @@ -32,15 +32,16 @@ jobs:

- name: Install ChatGPT
run: |
cd applications/Chat
cd applications/ColossalChat
pip install -v .
pip install -r requirements-test.txt

- name: Execute Unit Testing
run: |
cd applications/Chat
cd applications/ColossalChat
rm -rf ~/.cache/colossalai
pytest tests/
# pytest tests/
# Disabled temporally because some unit tests are not implemented
env:
NCCL_SHM_DISABLE: 1
MAX_JOBS: 8
4 changes: 2 additions & 2 deletions .github/workflows/run_colossalqa_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
github.event.pull_request.base.repo.full_name == 'hpcaitech/ColossalAI'
runs-on: [self-hosted, gpu]
container:
image: hpcaitech/pytorch-cuda:1.12.0-11.3.0
image: hpcaitech/pytorch-cuda:1.13.0-11.7.0
volumes:
- /data/scratch/test_data_colossalqa:/data/scratch/test_data_colossalqa
- /data/scratch/llama-tiny:/data/scratch/llama-tiny
Expand Down Expand Up @@ -51,4 +51,4 @@ jobs:
TEST_DATA_PATH_EN: /data/scratch/test_data_colossalqa/companies.txt
TEST_DATA_PATH_ZH: /data/scratch/test_data_colossalqa/companies_zh.txt
TEST_DOCUMENT_LOADER_DATA_PATH: /data/scratch/test_data_colossalqa/tests/*
SQL_FILE_PATH: /data/scratch/test_data_colossalqa/sql_file_path
SQL_FILE_PATH: /data/scratch/test_data_colossalqa/sql_file_path
38 changes: 0 additions & 38 deletions applications/Chat/benchmarks/README.md
View file
Open in desktop

This file was deleted.

Loading