Skip to content

[ColossalChat] Colossalchat upgrade#5759

Merged
YeAnbang merged 19 commits intomainfrom
colossalchat_upgrade
Jun 11, 2024
Merged

[ColossalChat] Colossalchat upgrade#5759
YeAnbang merged 19 commits intomainfrom
colossalchat_upgrade

Conversation

@YeAnbang
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YeAnbang YeAnbang requested a review from a team as a code owner May 28, 2024 08:01
@YeAnbang YeAnbang requested a review from TongLi3701 May 28, 2024 08:02
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang.

Some comments. Please also update corresponding README file and also add a table for supported models.

Comment thread applications/ColossalChat/coati/dataset/tokenization_utils.py Outdated
Comment thread applications/ColossalChat/coati/dataset/tokenization_utils.py Outdated
Comment thread applications/ColossalChat/coati/dataset/loader.py Outdated
Comment thread applications/ColossalChat/coati/models/critic.py
Comment thread applications/ColossalChat/examples/training_scripts/hostfile Outdated
@YeAnbang YeAnbang force-pushed the colossalchat_upgrade branch from 5139e68 to 77db216 Compare June 7, 2024 09:45
@YeAnbang YeAnbang requested a review from TongLi3701 June 8, 2024 10:23
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang, overall looks fine.

I left some questions, please address them and merge.

Comment thread applications/ColossalChat/examples/training_scripts/train_sft.py Outdated
Comment thread applications/ColossalChat/examples/training_scripts/train_sft.py Outdated
Comment thread applications/ColossalChat/examples/training_scripts/train_ppo.py
@YeAnbang YeAnbang merged commit 74f4a29 into main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants