Skip to content

[Hotfix/Inference]Hotfix the ci test of flash decoding#5766

Closed
isky-cd wants to merge 4 commits intohpcaitech:mainfrom
isky-cd:hotfix_test_flash_decoding
Closed

[Hotfix/Inference]Hotfix the ci test of flash decoding#5766
isky-cd wants to merge 4 commits intohpcaitech:mainfrom
isky-cd:hotfix_test_flash_decoding

Conversation

@isky-cd
Copy link
Copy Markdown
Contributor

@isky-cd isky-cd commented May 31, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Hotfixed the issue where CI unit tests failed due to the alibi mask. The main cause of the accuracy error is that the alibi mask introduces division between two decimals, leading to a large relative error.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@isky-cd isky-cd marked this pull request as ready for review May 31, 2024 03:22
@isky-cd isky-cd requested a review from a team as a code owner May 31, 2024 03:22
@ver217
Copy link
Copy Markdown
Contributor

ver217 commented Jun 3, 2024

fixed in #5752

@ver217 ver217 closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants