Skip to content

[Shardformer] Fix Shardformer FP8 communication training accuracy degradation#5921

Merged
GuangyaoZhang merged 1 commit intohpcaitech:feature/fp8_commfrom
BurkeHulk:fp8_fix
Jul 18, 2024
Merged

[Shardformer] Fix Shardformer FP8 communication training accuracy degradation#5921
GuangyaoZhang merged 1 commit intohpcaitech:feature/fp8_commfrom
BurkeHulk:fp8_fix

Conversation

@GuangyaoZhang
Copy link
Copy Markdown
Contributor

@GuangyaoZhang GuangyaoZhang commented Jul 18, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

resolve #5920

📝 What does this PR do?

Currently the FP8 communication in shardformer will have lower accuracy compared with FP16.

Following NVIDIA's practice. We have e4m3 forward and e5m2 backward.

GPT2 finetune(4GPU) Acc
FP16 0.755
FP8, e5m2 0.737
FP8, e4m3 forward and e5m2 backward 0.752

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@GuangyaoZhang GuangyaoZhang requested a review from BurkeHulk July 18, 2024 07:23
@GuangyaoZhang GuangyaoZhang requested a review from a team as a code owner July 18, 2024 07:23
@GuangyaoZhang GuangyaoZhang merged commit 62661cd into hpcaitech:feature/fp8_comm Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants