Skip to content

[Chat] Support overall loss, update KTO logging#5962

Merged
YeAnbang merged 1 commit intomainfrom
colossalchat
Aug 2, 2024
Merged

[Chat] Support overall loss, update KTO logging#5962
YeAnbang merged 1 commit intomainfrom
colossalchat

Conversation

@YeAnbang
Copy link
Copy Markdown
Contributor

@YeAnbang YeAnbang commented Aug 2, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YeAnbang YeAnbang requested a review from a team as a code owner August 2, 2024 06:53
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang,

Only one question here.

Comment thread applications/ColossalChat/coati/dataset/tokenization_utils.py
@TongLi3701 TongLi3701 self-requested a review August 2, 2024 09:26
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang.

@YeAnbang YeAnbang merged commit fe71917 into main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants