Skip to content

[Ring Attention] Improve comments & method arg naming#6085

Merged
Edenzzzz merged 8 commits intohpcaitech:mainfrom
Edenzzzz:fix_ring
Oct 16, 2024
Merged

[Ring Attention] Improve comments & method arg naming#6085
Edenzzzz merged 8 commits intohpcaitech:mainfrom
Edenzzzz:fix_ring

Conversation

@Edenzzzz
Copy link
Copy Markdown
Contributor

@Edenzzzz Edenzzzz commented Oct 9, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Improve comments on comm overlap

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Edenzzzz Edenzzzz requested a review from a team as a code owner October 9, 2024 15:28
@Edenzzzz Edenzzzz requested a review from ver217 October 9, 2024 15:28
@Edenzzzz Edenzzzz enabled auto-merge (squash) October 9, 2024 15:39
@Edenzzzz Edenzzzz added the documentation Improvements or additions to documentation label Oct 9, 2024
@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Oct 9, 2024

Thanks Liu zong @ver217

@Edenzzzz Edenzzzz changed the title [Ring Attention] Improve comments [Ring Attention] Improve comments & method arg naming Oct 12, 2024
@Edenzzzz Edenzzzz merged commit 62c13e7 into hpcaitech:main Oct 16, 2024
@Edenzzzz Edenzzzz deleted the fix_ring branch October 16, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants