Skip to content

[shardformer] optimize seq parallelism#6086

Merged
ver217 merged 6 commits intohpcaitech:mainfrom
ver217:feat/optim-sp
Oct 11, 2024
Merged

[shardformer] optimize seq parallelism#6086
ver217 merged 6 commits intohpcaitech:mainfrom
ver217:feat/optim-sp

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Oct 10, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. remove redundant communication of split-gather style seq parallel
  2. save gathered input for ring style seq parallel to avoid extra communication
  3. refactor linear 1d
  4. remove seq parallel overlap flag, as this communication is removed

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added enhancement New feature or request shardformer labels Oct 10, 2024
@ver217 ver217 requested a review from a team as a code owner October 10, 2024 07:48
@ver217 ver217 requested a review from kurisusnowdeng October 11, 2024 01:47
@ver217 ver217 merged commit dc2cdaf into hpcaitech:main Oct 11, 2024
@ver217 ver217 deleted the feat/optim-sp branch October 11, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request shardformer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants