Skip to content

[pipeline] hotfix backward for multiple outputs#6090

Merged
ver217 merged 2 commits intohpcaitech:mainfrom
ver217:hotfix/pp
Oct 16, 2024
Merged

[pipeline] hotfix backward for multiple outputs#6090
ver217 merged 2 commits intohpcaitech:mainfrom
ver217:hotfix/pp

Conversation

@ver217
Copy link
Copy Markdown
Contributor

@ver217 ver217 commented Oct 15, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Currrent implemention leads to multiple backward passes when outputs have multiple tensors. This PR fix this issue.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the bug Something isn't working label Oct 15, 2024
@ver217 ver217 requested a review from a team as a code owner October 15, 2024 10:02
@ver217 ver217 merged commit cd61353 into hpcaitech:main Oct 16, 2024
@ver217 ver217 deleted the hotfix/pp branch October 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants