Skip to content

[hotfix] fix lora ckpt saving format#6096

Merged
BurkeHulk merged 2 commits intohpcaitech:mainfrom
BurkeHulk:hotfix/lora_ckpt
Oct 21, 2024
Merged

[hotfix] fix lora ckpt saving format#6096
BurkeHulk merged 2 commits intohpcaitech:mainfrom
BurkeHulk:hotfix/lora_ckpt

Conversation

@BurkeHulk
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Fix the issue when saving lora ckpt using plugin, the saved ckpt is in ColoTensor format thus cannot be successfully loaded using PeftModel.from_pretrained.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@BurkeHulk BurkeHulk requested a review from a team as a code owner October 21, 2024 06:10
@BurkeHulk BurkeHulk merged commit dee63cc into hpcaitech:main Oct 21, 2024
@BurkeHulk BurkeHulk deleted the hotfix/lora_ckpt branch December 17, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants