Skip to content

[CI] Cleanup Dist Optim tests with shared helper funcs #6125

Merged
ver217 merged 4 commits intohpcaitech:mainfrom
Edenzzzz:fix_tests
Feb 12, 2025
Merged

[CI] Cleanup Dist Optim tests with shared helper funcs #6125
ver217 merged 4 commits intohpcaitech:mainfrom
Edenzzzz:fix_tests

Conversation

@Edenzzzz
Copy link
Copy Markdown
Contributor

@Edenzzzz Edenzzzz commented Nov 11, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Removes multiple redundant functions for ease of maintaince and code convention.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Edenzzzz Edenzzzz requested a review from a team as a code owner November 11, 2024 17:48
@Edenzzzz Edenzzzz changed the title [CI] Cleanup Dist Optim tests with common helper funcs [CI] Cleanup Dist Optim tests with common helper funcs and improve code style Nov 11, 2024
@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Tests passed locally.

@Issues-translate-bot
Copy link
Copy Markdown

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Tests passed locally.

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Nov 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Tests passed locally.

@ver217 Can we fix this bot? He seems confused LOL

@Edenzzzz Edenzzzz changed the title [CI] Cleanup Dist Optim tests with common helper funcs and improve code style [CI] Cleanup Dist Optim tests with shared helper funcs and improve code style Nov 11, 2024
@Edenzzzz Edenzzzz changed the title [CI] Cleanup Dist Optim tests with shared helper funcs and improve code style [CI] Cleanup Dist Optim tests with shared helper funcs Nov 11, 2024
@Edenzzzz
Copy link
Copy Markdown
Contributor Author

@duanjunwen Would love a review when you are not busy. Thanks!

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

@botbw Fixed test bugs and rebased to hopefully resolve the flash attn interface issue

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Dec 5, 2024

@botbw CI machine error. @ver217 Actually, could we allow some contributors to automatically triggers CIs? This could also encourage contribution.

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Feb 6, 2025

Thanks Liu Zong

@ver217
Copy link
Copy Markdown
Contributor

ver217 commented Feb 6, 2025

Rebasing the main branch is necessary, as CI has been updated.

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Feb 6, 2025

@ver217 rebased

@Issues-translate-bot
Copy link
Copy Markdown

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@ver217 foxes

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

@ver217 Ready to merge

@ver217 ver217 merged commit ec73f1b into hpcaitech:main Feb 12, 2025
@Edenzzzz Edenzzzz deleted the fix_tests branch February 12, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants