[CI] Cleanup Dist Optim tests with shared helper funcs #6125
Merged
ver217 merged 4 commits intohpcaitech:mainfrom Feb 12, 2025
Merged
[CI] Cleanup Dist Optim tests with shared helper funcs #6125ver217 merged 4 commits intohpcaitech:mainfrom
ver217 merged 4 commits intohpcaitech:mainfrom
Conversation
Contributor
Author
|
Tests passed locally. |
Tests passed locally. |
Contributor
Author
@ver217 Can we fix this bot? He seems confused LOL |
Contributor
Author
|
@duanjunwen Would love a review when you are not busy. Thanks! |
Contributor
Author
|
@botbw Fixed test bugs and rebased to hopefully resolve the flash attn interface issue |
Contributor
Author
ver217
approved these changes
Feb 6, 2025
Contributor
Author
|
Thanks Liu Zong |
Contributor
|
Rebasing the main branch is necessary, as CI has been updated. |
Contributor
Author
|
@ver217 rebased |
@ver217 foxes |
Contributor
Author
|
@ver217 Ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
📝 What does this PR do?
Removes multiple redundant functions for ease of maintaince and code convention.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.