Skip to content

[checkpointio]support asyncio for all models#6152

Merged
flybird11111 merged 18 commits intohpcaitech:mainfrom
flybird11111:3d-checkpoint-async-2
Dec 23, 2024
Merged

[checkpointio]support asyncio for all models#6152
flybird11111 merged 18 commits intohpcaitech:mainfrom
flybird11111:3d-checkpoint-async-2

Conversation

@flybird11111
Copy link
Copy Markdown
Contributor

@flybird11111 flybird11111 commented Nov 26, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@flybird11111 flybird11111 requested a review from a team as a code owner November 26, 2024 07:15
@flybird11111
Copy link
Copy Markdown
Contributor Author

flybird11111 commented Nov 27, 2024 •
edited
Loading

checkpoint benchmark
model size: 7b gpus numbers: 4; tp=2 pp=2
trace in gpu 0
use asyncio: True
image
image
use asyncio: False
image

@flybird11111 flybird11111 enabled auto-merge (squash) December 10, 2024 09:45
@flybird11111 flybird11111 changed the title [checkpointio]support asyncio for 3d [checkpointio]support asyncio for all models Dec 11, 2024
ver217
ver217 reviewed Dec 13, 2024
View reviewed changes
Comment thread colossalai/booster/plugin/torch_fsdp_plugin.py Outdated
Comment thread colossalai/checkpoint_io/hybrid_parallel_checkpoint_io.py Outdated
Comment thread colossalai/checkpoint_io/hybrid_parallel_checkpoint_io.py Outdated
Comment thread colossalai/utils/safetensors.py Outdated
@flybird11111 flybird11111 force-pushed the 3d-checkpoint-async-2 branch 2 times, most recently from 7b83bb5 to 8b1f649 Compare December 17, 2024 07:38
flybird11111 and others added 16 commits December 17, 2024 17:05
ver217
ver217 reviewed Dec 19, 2024
View reviewed changes
Comment thread colossalai/checkpoint_io/hybrid_parallel_checkpoint_io.py Outdated
Comment thread colossalai/utils/safetensors.py Outdated
Comment thread tests/test_checkpoint_io/test_torch_ddp_checkpoint_io.py
@flybird11111 flybird11111 merged commit 130229f into hpcaitech:main Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ver217 ver217 ver217 approved these changes

@wangbluo wangbluo wangbluo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flybird11111 @ver217 @wangbluo