[checkpointio] gather tensor before unpad it if the tensor is both padded and distributed#6168
Merged
ver217 merged 1 commit intohpcaitech:mainfrom Jan 21, 2025
Merged
[checkpointio] gather tensor before unpad it if the tensor is both padded and distributed#6168ver217 merged 1 commit intohpcaitech:mainfrom
ver217 merged 1 commit intohpcaitech:mainfrom
Conversation
Contributor
Author
|
request review from @flybird11111 @ver217 . |
request review from @flybird11111 @ver217 . |
11 tasks
Contributor
Author
|
it seems like one unittest ( |
ver217
approved these changes
Jan 20, 2025
Contributor
This was fixed in main branch. Could you rebase the main branch? |
Contributor
Author
Done. Approval is required again since we force push the code using rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
fixed #6167
📝 What does this PR do?
To prevent #6167, gather the tensor before unpad it if the tensor is both padded and distributed.

💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.