Skip to content

[hotfix]fix for async io #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ver217 merged 2 commits into from
Feb 14, 2025
Merged

[hotfix]fix for async io #6189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fc6a05
fix for async io
flybird11111 Feb 13, 2025
510ff7b
Merge branch 'hpcaitech:main' into main
flybird11111 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions colossalai/checkpoint_io/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,13 @@ def async_save_state_dict_shards(
checkpoint_file_path = os.path.join(checkpoint, shard_file)

if state_preprocess:
state_dict, _ = _flatten_optim_state_dict(state_dict=shard, seperator=".")
state_dict, metadata = _flatten_optim_state_dict(state_dict=shard, seperator=".")
else:
state_dict = shard
metadata = None

# Only save on master rank.
writer = save(checkpoint_file_path, state_dict=state_dict)
writer = save(checkpoint_file_path, state_dict=state_dict, metadata=metadata)
writers.append(writer)
shard_filenames.append(shard_file)
del shard
Expand Down Expand Up @@ -377,9 +378,10 @@ def async_move_save_state_dict_shards(
checkpoint_file_path = os.path.join(checkpoint, shard_file)

if state_preprocess:
state_dict, _ = _flatten_optim_state_dict(state_dict=shard)
state_dict, metadata = _flatten_optim_state_dict(state_dict=shard)
else:
state_dict = shard
metadata = None

if pinned_state_dict is not None:
sub_pinned_state_dict = {k: pinned_state_dict[k] for k in state_dict.keys()}
Expand All @@ -388,7 +390,7 @@ def async_move_save_state_dict_shards(
returned_state_dict.update(sub_pinned_state_dict)

# Only save on master rank.
writer = move_and_save(checkpoint_file_path, state_dict, sub_pinned_state_dict)
writer = move_and_save(checkpoint_file_path, state_dict, sub_pinned_state_dict, metadata)
writers.append(writer)
shard_filenames.append(shard_file)
del shard
Expand Down