Skip to content

[feat] Fix Vllm, logprob, add filtering, temperature annealing, lr descent#6250

Merged
YeAnbang merged 4 commits intogrpo-latestfrom
grpo-latest-dev
Mar 21, 2025
Merged

[feat] Fix Vllm, logprob, add filtering, temperature annealing, lr descent#6250
YeAnbang merged 4 commits intogrpo-latestfrom
grpo-latest-dev

Conversation

@YeAnbang
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YeAnbang YeAnbang requested a review from a team as a code owner March 21, 2025 02:27
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang, overall looks good.

I just have a few comments, please have a look.

Comment thread applications/ColossalChat/coati/distributed/consumer.py
Comment thread applications/ColossalChat/coati/distributed/inference_backend.py Outdated
Comment thread applications/ColossalChat/coati/distributed/producer.py
@TongLi3701 TongLi3701 self-requested a review March 21, 2025 08:23
Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang,

Overall look good.

@YeAnbang YeAnbang merged commit 489f215 into grpo-latest Mar 21, 2025
YeAnbang added a commit that referenced this pull request Aug 5, 2025
[feat] Fix Vllm, logprob, add filtering, temperature annealing, lr descent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants