Controller mapping fixes #17412
Merged
Controller mapping fixes #17412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into setting empty events This had some not-so-good consequences, like inability to map anything in VR, and sometimes empty MultiMappings would result that we could end up asserting on before the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where stray KEY_UP events could confuse the control mapper into setting empty events.
This had some not-so-good consequences, like inability to map anything in VR (due to code spamming mouse-wheel key_up events), and sometimes empty MultiMappings would result that we could end up asserting on before the previous commit. Replaced the assert with log, and add paranoia-level checks, too.
Fixes #17411