Fix running some file formats from the Downloads folder #17466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how we mount stuff, we need to be able to navigate one step up from the executable, and then re-attach the executable filename. To allow this, in content URIs, treat ':' as a directory separator for navigation purposes. End result, you can now download cube.elf from the website and run it directly from Downloads without using a file manager to move it.
hrydgard
added
Platform-specific (Android)
Scoped Storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how we mount stuff, we need to be able to navigate one step up from the executable, and then re-attach the executable filename. To allow this, in single-file (non-tree) content URIs, treat ':' as a directory separator for navigation purposes. Fixes #17462 in a way (see that issue for more information).
End result, you can now download cube.elf from the website and run it directly from Downloads without using a file manager to move it.
Seems to work just fine and fixes quite an annoying issue, so getting it in for 1.15.4.