Skip to content

Conversation

@zhykzhykzhyk
Copy link
Contributor

Make changes in native module take effect.
Add a way to turn off vsync in non-win32 platform.

See hrydgard/native#277

@zhykzhykzhyk zhykzhykzhyk changed the title Vsync support for non-win32 platform Vsync control support for non-win32 platform Jun 27, 2015
@unknownbrackets
Copy link
Collaborator

Cool. I'm not sure if we can do the UpdateRunLoop change exactly like that, for two reasons:

  1. Blackberry and some other platforms call UpdateRunLoop directly and don't want it to perform time throttling, especially when on devices with 58 or 57 fps native framerates.
  2. While paused/loading this might make it burn the CPU again, since you're not checking inited. Not sure.

Maybe it would be better to have a separate throttled function that calls UpdateRunLoop and is called be other places where it makes sense?

-[Unknown]

@zhykzhykzhyk
Copy link
Contributor Author

  1. I think that redundant throttling have no effect on those device, but I have no device to perform the test. (Actually on all devices that have vsync on, time throttling is redundant.)
  2. I found it missing.

@unknownbrackets
Copy link
Collaborator

@hrydgard what's your opinion? Should we look to rebase this and hrydgard/native#277 into the newly integrated native world?

-[Unknown]

@hrydgard hrydgard added this to the v1.4.0 milestone Dec 1, 2016
@hrydgard hrydgard modified the milestones: v1.5.0, v1.4.0 Feb 19, 2017
@hrydgard
Copy link
Owner

hrydgard commented Jun 6, 2017

Closing this for now, there doesn't seem to be much interest.

@hrydgard hrydgard closed this Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants