Please consider the following formatting changes to #2855#1
Closed
alibuild wants to merge 1 commit intohscheid:masterfrom
Closed
Please consider the following formatting changes to #2855#1alibuild wants to merge 1 commit intohscheid:masterfrom
alibuild wants to merge 1 commit intohscheid:masterfrom
Conversation
alibuild
force-pushed
the
alibot-cleanup-2855
branch
from
f7a1bb8 to
8164277
Compare
hscheid
pushed a commit
that referenced
this pull request
Oct 24, 2023
) * Implement efficiency computation macro for D2H * Add new line at the end of config file * Fix bug in TH2 projection, add safety for asymmetric error setting when converting TEfficiency to TH1, and add pt binning option * Add missing loop on all pt bins after rebinning * Remove scaling after rebinning (not nedded), re-organise helper methods, try solving MegaLinter errors * Add safety for canvas file extension and try to solve mypy errors * New attempt to solve mypy errors * Try to fix type of save_canvas() last argument + import-error on modules * Add copyright + attempt to solve mypy error * Attempt to solve pyright error #1 * Second attempt to solve pyright error * Apply linters automatic fixes * Apply Vit's comments * Remove empty line between ROOT and style_formatter imports * Fix typo found by Fabio --------- Co-authored-by: Alexandre Bigot <abigot@sbgat402.in2p3.fr>
hscheid
pushed a commit
that referenced
this pull request
Oct 24, 2023
AliceO2Group#3658) * preliminary support for Monte Carlo analysis + support for PROCESS_SWITCH + switch to templates in few function to trim down code bloat * fix for formatter #1 * implementing Victor comments * fix for formatter #2
hscheid
pushed a commit
that referenced
this pull request
Dec 18, 2023
* templating the rest * reply to Victor comments * fix for formatter #1 * removed commented code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.