Update build.yaml#2
Closed
rfranco wants to merge 1 commit into
Closed
Conversation
thomaslestum
added a commit
to thomaslestum/pobfrontend
that referenced
this pull request
Mar 7, 2026
Four separate issues prevented PoB from running on ARM64 macOS:
1. Native fullscreen crash (OpenGL context destroyed on transition)
- Add macos_window.mm with disableNativeFullscreen() that strips
NSWindowCollectionBehaviorFullScreenPrimary from the NSWindow,
making the green button zoom/maximize instead of entering native
fullscreen. Called via QTimer::singleShot(500ms) after show() —
must not be called from initializeGL() as winId() there disrupts
the GL surface.
- Also set Qt::WindowFullscreenButtonHint false in POBWindow ctor.
- Wire macos_window.mm into meson.build (objcpp language + AppKit).
2. Lua PANIC on any error ("error in error handling")
- l_PCall uses "traceback" from the Lua registry as its error
handler, but nothing ever stored it there. Any Lua error inside
PCall caused LUA_ERRERR -> unprotected lua_error -> PANIC.
- Fix: store debug.traceback in the registry after luaL_openlibs.
3. Crash on skill tree / tooltips (invalid font 'FONTIN')
- PoB's Lua code uses FONTIN, FONTIN ITALIC, FONTIN SC, and
FONTIN SC ITALIC throughout, but the fontMap in DrawString only
knew FIXED, VAR, and VAR BOLD. luaL_checkoption raised a Lua
error for any FONTIN call, which then hit bug hsource#2 -> PANIC.
- Fix: add all four FONTIN variants (mapped to Liberation Sans)
in DrawString, DrawStringWidth, and DrawStringCursorIndex.
4. Hardcoded SDK path breaks builds on most machines
- meson.build had -isysroot /Library/.../MacOSX12.3.sdk hardcoded,
failing on any machine without that exact SDK installed.
- Fix: remove the -isysroot flag; use the default host SDK.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.