This repository was archived by the owner on Mar 5, 2026. It is now read-only.
HTML repr for Maps#227
Merged
JoshKarpel merged 5 commits intohtcondor:v0.7.0from Aug 20, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.7.0 #227 +/- ##
=====================================
Coverage 84% 84%
=====================================
Files 77 78 +1
Lines 3795 3813 +18
Branches 391 393 +2
=====================================
+ Hits 3208 3226 +18
Misses 503 503
Partials 84 84
|
JoshKarpel
suggested changes
Aug 17, 2020
Contributor
JoshKarpel
left a comment
JoshKarpel
left a comment
There was a problem hiding this comment.
Some quibbles about the code itself, but the structure looks good.
Comment on lines
+168
to
+184
| sc = collections.Counter(self.component_statuses) | ||
| row: Dict[str, Union[str, int, float]] = {"tag": self.tag} | ||
|
|
||
| for status in state.ComponentStatus.display_statuses(): | ||
| row[status.value.lower()] = sc[status] | ||
|
|
||
| tag = row["tag"] | ||
| held = row["held"] | ||
| errored = row["errored"] | ||
| idle = row["idle"] | ||
| running = row["running"] | ||
| completed = row["completed"] | ||
|
|
||
| local_data = utils.num_bytes_to_str(self.local_data) | ||
| max_memory = utils.num_bytes_to_str(max(self.memory_usage) * 1024 * 1024) | ||
| max_runtime = str(max(self.runtime)) | ||
| total_runtime = str(sum(self.runtime, datetime.timedelta())) |
Contributor
There was a problem hiding this comment.
The row dictionary seems unhelpful here; just pull the data directly from self.component_statuses (you can still use state.ComponentStatus.display_statuses() to get the ones to show), and use self.tag for the tag.
Contributor
|
This is part of work on #53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maps could be displayed in HTML format