Skip to content

minor vim bind improvements#106

Closed
Ckath wants to merge 2 commits intohtop-dev:masterfrom
Ckath:vimmode_arrows
Closed

minor vim bind improvements#106
Ckath wants to merge 2 commits intohtop-dev:masterfrom
Ckath:vimmode_arrows

Conversation

@Ckath
Copy link
Copy Markdown
Contributor

@Ckath Ckath commented Sep 8, 2020

this addresses two things mainly:

  1. keep arrow keys working in vim mode
  2. allow hjkl movement in panels (open files, environment vars, etc)

the arrow keys are restored in vimmode by dropping H and K keys when vimmode is on and simply remapping HJKL to hjkl directly without the need to ruin arrow keys. hjkl movement in panels is simply added regardless of vimmode, as this doesnt collide with anything here and in the existing codebase it isnt trivial to access the settings from within panel.c

this would fix #69

Ckath added 2 commits September 2, 2020 17:15
@Ckath
redo vimmode keybind mapping
75d4730 
- keep arrow keys working inside vimmode
- drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
@Ckath
allow hjkl for movement in panels
05431a6
natoscott added a commit that referenced this pull request Sep 14, 2020
@natoscott
Revert the vim_mode setting for now, needs a rethink
c9ecd0f 
There have been too many bugs reported in vim_mode, and
the proposed fixes are increasingly fragile - hence we
have decided to back it out for now.  For reference:

   #69
   #37
   #106

The whitespace changes also arrived in commit 12805f6
not sure what that was about, but backed out as well.
@cgzones cgzones added needs-discussion 🤔 Changes need to be discussed and require consent needs-rebase Pull request needs to be rebased and conflicts to be resolved labels Sep 15, 2020
@natoscott
Copy link
Copy Markdown
Member

natoscott commented Sep 15, 2020

See also: #37

@natoscott natoscott closed this Sep 15, 2020
@BenBE BenBE mentioned this pull request May 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-discussion 🤔 Changes need to be discussed and require consent needs-rebase Pull request needs to be rebased and conflicts to be resolved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

arrow keys broken in vim mode

3 participants

@Ckath @natoscott @cgzones