PCP: DynamicMeters: Add Meter Choice framework#1081
Open
smalinux wants to merge 10 commits intohtop-dev:mainfrom
Open
PCP: DynamicMeters: Add Meter Choice framework#1081smalinux wants to merge 10 commits intohtop-dev:mainfrom
smalinux wants to merge 10 commits intohtop-dev:mainfrom
Conversation
smalinux
commented
Sep 12, 2022
BenBE
requested changes
Sep 12, 2022
Member
BenBE
left a comment
BenBE
left a comment
There was a problem hiding this comment.
Not quite happy with the ATTR_UNUSED littered all over the headers when it's actually just an implementation detail for the C files (except when static inline-ing the implementation in the header.
Also the ATTR_UNUSED usage and (void)var;-casts are mixed. Should only use one of both (unless there's an assert forcing the cast).
smalinux
force-pushed
the
ip_pcp_dm
branch
3 times, most recently
from
b6aeeba to
7d6d345
Compare
Member
+1 - this feedback is more related to PR #200 though isn't it? |
natoscott
requested changes
Sep 13, 2022
Member
smalinux
force-pushed
the
ip_pcp_dm
branch
2 times, most recently
from
c869583 to
bc54719
Compare
Improves stacktraces in case the function pointer is NULL, mainly useful for development. Similar to be568b1 ("Object: assert callbacks exists")
Add support for meters to have different choices, e.g. different sources , modes, ... , which can be selected by the user.
Add choice support to display IP addresses based on the selected network interface. Currently only implemented on Linux and FreeBSD.
Currently only implemented on Linux and FreeBSD.
Use a meter attached data structure instead of static variables, to uncouple different meters for choice support.
Display the network usage based on the selected network interface. Currently only implemented on Linux and FreeBSD.
Show the input and maximum temperature of any available libsensors temperature sensor. Related: htop-dev#610
Show the input, minimum and maximum fan speed of any available libsensors fan sensor.
Related: htop-dev#200 && htop-dev#669 Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Avoid duplicating metric name and descriptor lookups just for Choice meters as these have already been performed as part of initialization - use the cached values instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #200 && #669