Refactor the cmdline heuristics#1365
Merged
cgzones merged 2 commits intohtop-dev:mainfrom Jan 27, 2024
Merged
Conversation
BenBE
added
enhancement
This was
linked to
issues
Jan 9, 2024
Closed
BenBE
force-pushed
the
cmdline-checkexe
branch
from
9cc2ffa to
b9a5bdb
Compare
cgzones
reviewed
Jan 10, 2024
BenBE
force-pushed
the
cmdline-checkexe
branch
from
b9a5bdb to
8b0c62b
Compare
This potentially avoids guessing the right path in the presence of spaces inside the executable path.
BenBE
force-pushed
the
cmdline-checkexe
branch
from
8b0c62b to
271661b
Compare
cgzones
approved these changes
Jan 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly a refactor of the command line scanning code.
This tracks if we actually hit any of the patterns we are looking for. This now also properly tracks elements starting at the first character (like relative paths without
/).When the command line starts with the executable name as reported in
/proc/<pid>/exethe filesystem check is skipped, thus improving performance.Improving code flow and documentation of what this does. A big part of the changes can be traced back to flatten the code be re-arranging parts of it.