Disable basename matching for kernel threads#1392
Conversation
Kernel threads are commonly not based on an executable and their cmdline therefore just a human readable string. On Linux this string might contain slashes, e.g. kworker/7:5H-ttm, which cause Process_writeCommand() to print only the trailing parts if the option *Show Program Path* is disabled. Reported-and-Suggested-By: mmrmaximuzz Fixes: htop-dev#1391
BenBE
left a comment
BenBE
left a comment
There was a problem hiding this comment.
ACK.
An alternative would be highlighting the first part for kernel threads instead. Fine either way.
I suppose that highlighting any part of a kernel thread name could be misleading. And it seems to be broken already, look how it could be rendered for some threads:
Not only With @cgzones patch all the highlighting for kernel threads is gone as well, I worked with kernel for some time and at least for me it looks more natural. |
|
Okay. Noticed the partial highlighting there too. My suggestion was to just highlight |
3 participants
Kernel threads are commonly not based on an executable and their cmdline therefore just a human readable string.
On Linux this string might contain slashes, e.g. kworker/7:5H-ttm, which cause Process_writeCommand() to print only the trailing parts if the option Show Program Path is disabled.
Reported-and-Suggested-By: mmrmaximuzz
Fixes: #1391
/cc @mmrmaximuzz