Skip to content

CI: Update LLVM repo and use ubuntu-latest for building "unsupported" htop#1635

Merged
BenBE merged 2 commits intohtop-dev:mainfrom
Explorer09:ci-ubuntu-noble
Mar 31, 2025
Merged

CI: Update LLVM repo and use ubuntu-latest for building "unsupported" htop#1635
BenBE merged 2 commits intohtop-dev:mainfrom
Explorer09:ci-ubuntu-noble

Conversation

@Explorer09
Copy link
Copy Markdown
Contributor

No description provided.

@BenBE BenBE added this to the 3.4.1 milestone Mar 12, 2025
@BenBE BenBE added the build system 🔧 Affects the build system rather then the user experience label Mar 12, 2025
Use the "ubuntu-latest" image to build the "unsupported" version of
htop.
The Clang build jobs in htop's CI now grabs the Ubuntu codename
automatically from the /etc/os-release file of the Ubuntu image.
This frees us the need to update the codenames when the "ubuntu-latest"
image gets updated upstream (by GitHub).

At the time of the writing, the "ubuntu-latest" image contains
"ubuntu-24.04" (noble).

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Copy link
Copy Markdown
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Any objections to LLVM 20?

@Explorer09
Copy link
Copy Markdown
Contributor Author

LGTM.

Any objections to LLVM 20?

LLVM-20 would pop out a lot of -Wshorten64-to-32 warnings (#1513), and it is fine to upgrade to that as long as the warning is disabled (-Wno-shorten64-to-32) temporarily.

@BenBE
Copy link
Copy Markdown
Member

BenBE commented Mar 31, 2025

Let's do this after #1513 has been addressed …

@BenBE BenBE merged commit 60dd0f1 into htop-dev:main Mar 31, 2025
19 checks passed
@Explorer09 Explorer09 deleted the ci-ubuntu-noble branch March 31, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build system 🔧 Affects the build system rather then the user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants