Skip to content

Don't write to htoprc file if it's not owned by EUID #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenBE merged 1 commit into from
Jan 28, 2026
Merged

Don't write to htoprc file if it's not owned by EUID #1866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,12 @@ static bool Settings_read(Settings* this, const char* fileName, const Machine* h
return false;
}
} else {
// Check if this is a regular file
// Write the config only if the file is:
// (1) a regular file (not a device file like /dev/null), and
// (2) owned by the effective user ID
struct stat sb;
int err = fstat(fd, &sb);
this->writeConfig = !err && S_ISREG(sb.st_mode);
this->writeConfig = !err && S_ISREG(sb.st_mode) && sb.st_uid == geteuid();
}
}

Expand Down
Loading