Merged
Conversation
Member
cgzones
commented
Oct 9, 2020
cgzones
commented
cgzones
force-pushed
the
NetworkIOMeter
branch
from
78378fe to
caf9363
Compare
BenBE
reviewed
Oct 9, 2020
Member
BenBE
left a comment
BenBE
left a comment
There was a problem hiding this comment.
Overall patch LGTM.
But isn't having such a prominent feature display 0 on every platform except Linux somewhat strange? Quick search returned for FreeBSD to use systat -ifstat, which should work on most other BSD flavors too.
Member
Author
|
This is just a first draft. I'll try to setup a FreeBSD vm on the weekend and play around with sysctl(3). |
cgzones
force-pushed
the
NetworkIOMeter
branch
3 times, most recently
from
b6120b9 to
5d51541
Compare
cgzones
force-pushed
the
NetworkIOMeter
branch
from
5d51541 to
9d7fd76
Compare
Member
Author
|
Added implementation for FreeBSD. |
cgzones
force-pushed
the
NetworkIOMeter
branch
3 times, most recently
from
1fdfb58 to
d442b9b
Compare
cgzones
force-pushed
the
NetworkIOMeter
branch
from
d442b9b to
31f903d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.