Merged
Conversation
- Remove local types and function from header file
- Reduce OpenFiles_Data to neccessary size
- Print file access mode (r/w/u)
- Fix memory leak on consecutive items without an intermediate file item:
==15257==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 120 byte(s) in 12 object(s) allocated from:
#0 0x48c864 in strdup (htop/htop+0x48c864)
#1 0x542f68 in xStrdup htop/XAlloc.c:71:17
#2 0x50e225 in OpenFilesScreen_getProcessData htop/OpenFilesScreen.c:112:25
htop-dev#3 0x50cd17 in OpenFilesScreen_scan htop/OpenFilesScreen.c:141:35
htop-dev#4 0x4fd3eb in InfoScreen_run htop/InfoScreen.c:81:35
htop-dev#5 0x4d58bb in actionLsof htop/Action.c:361:4
htop-dev#6 0x501766 in MainPanel_eventHandler htop/MainPanel.c:80:19
htop-dev#7 0x5289fa in ScreenManager_run htop/ScreenManager.c:227:19
htop-dev#8 0x4f748e in main htop/htop.c:300:4
htop-dev#9 0x7ff73e0d8cc9 in __libc_start_main csu/../csu/libc-start.c:308:16
SUMMARY: AddressSanitizer: 120 byte(s) leaked in 12 allocation(s).
BenBE
reviewed
Oct 9, 2020
Member
BenBE
left a comment
There was a problem hiding this comment.
LGTM.
Just a minor style note: In the long switch statement you could consider to just add a default: label to indicate all, not just the known columns, to be ignored.
Member
Author
The body of that case statement is empty, so every compiler should drop it entirely; it's mainly a in-code documentation which fields are deliberately ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove local types and function from header file
Reduce OpenFiles_Data to neccessary size
Print file access mode (r/w/u)
Fix memory leak on consecutive items without an intermediate file item:
==15257==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 120 byte(s) in 12 object(s) allocated from:
#0 0x48c864 in strdup (htop/htop+0x48c864)
Create ci.yml #1 0x542f68 in xStrdup htop/XAlloc.c:71:17
fixed display of blank bars #2 0x50e225 in OpenFilesScreen_getProcessData htop/OpenFilesScreen.c:112:25
Migrate previous releases #3 0x50cd17 in OpenFilesScreen_scan htop/OpenFilesScreen.c:141:35
CI improvements #4 0x4fd3eb in InfoScreen_run htop/InfoScreen.c:81:35
Fix build on FreeBSD #5 0x4d58bb in actionLsof htop/Action.c:361:4
Switch to Python 3 #6 0x501766 in MainPanel_eventHandler htop/MainPanel.c:80:19
Fix out-of-tree builds #7 0x5289fa in ScreenManager_run htop/ScreenManager.c:227:19
CI: Add a HWLOC enabled job #8 0x4f748e in main htop/htop.c:300:4
[Q] How to move forward with the generated header files? #9 0x7ff73e0d8cc9 in __libc_start_main csu/../csu/libc-start.c:308:16
SUMMARY: AddressSanitizer: 120 byte(s) leaked in 12 allocation(s).