Skip to content

Process Field Rework#405

Merged
cgzones merged 5 commits intohtop-dev:masterfrom
cgzones:misc
Dec 19, 2020
Merged

Process Field Rework#405
cgzones merged 5 commits intohtop-dev:masterfrom
cgzones:misc

Conversation

@cgzones
Copy link
Copy Markdown
Member

@cgzones cgzones commented Dec 15, 2020

  • Use only one enum instead of a global and a platform specific one
  • Drop Platform_numberOfFields global variable - use LAST_PROCESSFIELD
  • LinuxProcess: drop dead Process columns
  • Merge Process_pidColumns into Process_fields and rework auto-fit for PID-like columns

Copy link
Copy Markdown
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BenBE BenBE added this to the 3.0.4 milestone Dec 17, 2020
@cgzones cgzones force-pushed the misc branch 2 times, most recently from 3023554 to a2d8d5d Compare December 18, 2020 15:00
Copy link
Copy Markdown
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should go after #411. LGTM.

@BenBE BenBE mentioned this pull request Dec 19, 2020
Use only one enum instead of a global and a platform specific one.
Drop Platform_numberOfFields global variable.
Set known size of Process_fields array
Now that the global format variable Process_pidFormat is gone, enable
the compiler warning -Wformat=2.
@cgzones cgzones merged commit f614b8a into htop-dev:master Dec 19, 2020
@cgzones cgzones deleted the misc branch December 19, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants