RichString_setAttrn: refactor to take a length instead of a stop index#460
Merged
fasterit merged 1 commit intohtop-dev:masterfrom Jan 11, 2021
Merged
RichString_setAttrn: refactor to take a length instead of a stop index#460fasterit merged 1 commit intohtop-dev:masterfrom
fasterit merged 1 commit intohtop-dev:masterfrom
Conversation
cgzones
force-pushed
the
RichString_attrn
branch
from
e85d0c3 to
3693c63
Compare
BenBE
reviewed
Jan 10, 2021
Member
BenBE
left a comment
BenBE
left a comment
There was a problem hiding this comment.
LGTM. Some minor optional points for consideration.
cgzones
force-pushed
the
RichString_attrn
branch
from
3693c63 to
1a2b20f
Compare
BenBE
approved these changes
Jan 10, 2021
cgzones
force-pushed
the
RichString_attrn
branch
from
1a2b20f to
d1fad3a
Compare
BenBE
approved these changes
Jan 10, 2021
Comment on lines
80
to
81
| ch->attr = attrs; | ||
| ch++; |
Member
There was a problem hiding this comment.
Optional: Keep ch const and use ch[i]->attr for access.
Comment on lines
117
to
118
| *ch = (*ch & 0xff) | attrs; | ||
| ch++; |
cgzones
force-pushed
the
RichString_attrn
branch
from
d1fad3a to
3bb731c
Compare
BenBE
approved these changes
Jan 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #459