add option (-U, --no-unicode) to disable unicode at runtime#50
add option (-U, --no-unicode) to disable unicode at runtime#50natoscott merged 1 commit intohtop-dev:masterfrom
Conversation
|
doesnt seem needed anymore after #54, which I think would be the preferable solution |
I think they match up perfectly. Disabling Unicode, even if the terminal is capable, looks like a valid case. |
|
Let me explain my use case: The graph meters use braille characters to display. This works fine if braille characters are available (X terminal), but fails if not: Only squares are displayed then. I use this to switch to ASCII mode in virtual (non-X) terminal. UTF-8 is supported there, just glyphs are missing. |
natoscott
left a comment
There was a problem hiding this comment.
This needs a man page update I think...? Thanks.
|
Ah, right... Will add that. |
6805e9d to
75950ed
Compare
|
Rebased and added the man page change. |
natoscott
left a comment
There was a problem hiding this comment.
Thanks - another small thing, it looks like all the #ifdef conditionals in htop.c could be removed around the new code? The default behaviour without HAVE_LIBNCURSESW is to not 'allowUnicode', right? - it seems that code can be simplified further, always allowing the -U/--no-unicode option to be entered by the user, no matter how htop is built.
75950ed to
db5adbe
Compare
|
Probably you are right. :) |
No description provided.