MemoryMeter: show shared memory before cached#566
Merged
fasterit merged 1 commit intohtop-dev:masterfrom Mar 19, 2021
Merged
Conversation
Shared memory is less free-able than cached memory. Show it beforehand.
BenBE
approved these changes
Mar 18, 2021
natoscott
approved these changes
Mar 18, 2021
Member
natoscott
left a comment
natoscott
left a comment
There was a problem hiding this comment.
LGTM too - one thing maybe for the future, it would be nice to change those hard coded values array offsets to something symbolic (enum) ... then the code would describe itself, and the new comments here (and commented-out code lines) wouldn't be needed here.
Obviously, doing this affects alot of meters though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared memory is less free-able than cached memory.
Show it beforehand.
Follow up of: #558