Abstract htop main function to allow for a platform binary#575
Merged
natoscott merged 1 commit intohtop-dev:masterfrom Mar 25, 2021
Merged
Abstract htop main function to allow for a platform binary#575natoscott merged 1 commit intohtop-dev:masterfrom
natoscott merged 1 commit intohtop-dev:masterfrom
Conversation
BenBE
requested changes
Mar 23, 2021
Member
BenBE
left a comment
BenBE
left a comment
There was a problem hiding this comment.
LGTM. Although the noise in Makefile.am is kinda a bit overkill (at least for now).
|
|
||
| #include "Action.h" | ||
| #include "CRT.h" | ||
| #include "CommandLine.h" |
Member
There was a problem hiding this comment.
The #include "CommandLine.h" should go right after #include "config.h".
Member
Author
There was a problem hiding this comment.
LGTM. Although the noise in
Makefile.amis kinda a bit overkill (at least for now).
Yep - makes more sense once we have the PCP front-end of course.
Member
There was a problem hiding this comment.
ACK. That's what I meant with the parens …
natoscott
force-pushed
the
refactor-command-line
branch
from
9d9c49b to
ef95534
Compare
BenBE
approved these changes
Mar 23, 2021
cgzones
approved these changes
Mar 24, 2021
| @@ -0,0 +1,7 @@ | |||
| #ifndef HEADER_CommandLine | |||
| #define HEADER_CommandLine | |||
|
|
|||
Member
There was a problem hiding this comment.
Do you like to add a Copyright header?
One review request relating to the PCP platform is to have a clearly separate binary from the regular htop so that we have no confusion as to what is being requested to run, to aid debugging, and a bunch of other good reasons. This commit renames htop.c to CommandLine.c and provides a minimal htop main function for 'native' platforms to use. The PCP version of this will setup libpcp.so and then call the same CommandLine_run function as regular htop. Related to htop-dev#536
natoscott
force-pushed
the
refactor-command-line
branch
from
ef95534 to
36389fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One review request relating to the PCP platform is to have
a clearly separate binary from the regular htop so that we
have no confusion as to what is being requested to run, to
aid debugging, and a bunch of other good reasons.
This commit renames htop.c to CommandLine.c and provides a
minimal htop main function for 'native' platforms to use.
The PCP version of this will setup libpcp.so and then call
the same CommandLine_run function as regular htop.
Related to #536