NetBSD: Rework CPU counting.

[fraggerfox]

This is the continuation of the work done in #656

Refactors the code in NetBSD to comply with the changes.

[BenBE]

What's wrong with writing it like this?

[fraggerfox]

@BenBE I should probably visit the code base again once the merge is done, and refactor some of the variable names used, I liked the above suggestion to give it meaningful names in a self-documenting style.

[BenBE]

When tweaking some final stuff I noticed one last thing with the online field in the CPUData structure: The field is only ever written for the average (CPU 0), but never for any of the actual cores (1..super->activeCPUs). Please recheck if there is anything missing or drop a short note if I just missed some code that properly updates the online information.

[fraggerfox]

When tweaking some final stuff I noticed one last thing with the online field in the CPUData structure: The field is only ever written for the average (CPU 0), but never for any of the actual cores (1..super->activeCPUs). Please recheck if there is anything missing or drop a short note if I just missed some code that properly updates the online information.

You are right, I have only done minimal implementation of CPU counting and I looked around in the documentation to understand how to do check on multiple CPUs and see if online / offline CPUs can be detected. Due to the lack of time and being unable to find the exact information I am looking for, I went for the base implementation of having to deal only with CPU 0. I will need a bit more time from my end to figure out how multi CPU stuff works in NetBSD.

I can do a follow up with @alarixnia and see if I can learn more about this after the merge.

[BenBE]

Okay, then I'd suggest to skip the online field in those structures for now and add it in, when it gives practical information.

For now I'd propose to amend as follows and do the per-core online status in a follow-up PR:

$ git diff
diff --git a/netbsd/NetBSDProcessList.c b/netbsd/NetBSDProcessList.c
index c35946ae..a3530de7 100644
--- a/netbsd/NetBSDProcessList.c
+++ b/netbsd/NetBSDProcessList.c
@@ -93,7 +93,6 @@ static void NetBSDProcessList_updateCPUcount(ProcessList* super) {
       memset(dAvg, '\0', sizeof(CPUData));
       dAvg->totalTime = 1;
       dAvg->totalPeriod = 1;
-      dAvg->online = true;
 
       for (unsigned int i = 0; i < super->existingCPUs; i++) {
          CPUData* d = &opl->cpuData[i + 1];
@@ -480,5 +479,5 @@ bool ProcessList_isCPUonline(const ProcessList* super, unsigned int id) {
    assert(id < super->existingCPUs);
 
    const NetBSDProcessList* npl = (const NetBSDProcessList*) super;
-   return npl->cpuData[id + 1].online;
+   return true;
 }
diff --git a/netbsd/NetBSDProcessList.h b/netbsd/NetBSDProcessList.h
index 14b09312..1d1407d8 100644
--- a/netbsd/NetBSDProcessList.h
+++ b/netbsd/NetBSDProcessList.h
@@ -39,7 +39,6 @@ typedef struct CPUData_ {
    unsigned long long int idlePeriod;
 
    double frequency;
-   bool online;
 } CPUData;
 
 typedef struct NetBSDProcessList_ {

[fraggerfox]

Okay, then I'd suggest to skip the online field in those structures for now and add it in, when it gives practical information.

For now I'd propose to amend as follows and do the per-core online status in a follow-up PR:

$ git diff
diff --git a/netbsd/NetBSDProcessList.c b/netbsd/NetBSDProcessList.c
index c35946ae..a3530de7 100644
--- a/netbsd/NetBSDProcessList.c
+++ b/netbsd/NetBSDProcessList.c
@@ -93,7 +93,6 @@ static void NetBSDProcessList_updateCPUcount(ProcessList* super) {
       memset(dAvg, '\0', sizeof(CPUData));
       dAvg->totalTime = 1;
       dAvg->totalPeriod = 1;
-      dAvg->online = true;
 
       for (unsigned int i = 0; i < super->existingCPUs; i++) {
          CPUData* d = &opl->cpuData[i + 1];
@@ -480,5 +479,5 @@ bool ProcessList_isCPUonline(const ProcessList* super, unsigned int id) {
    assert(id < super->existingCPUs);
 
    const NetBSDProcessList* npl = (const NetBSDProcessList*) super;
-   return npl->cpuData[id + 1].online;
+   return true;
 }
diff --git a/netbsd/NetBSDProcessList.h b/netbsd/NetBSDProcessList.h
index 14b09312..1d1407d8 100644
--- a/netbsd/NetBSDProcessList.h
+++ b/netbsd/NetBSDProcessList.h
@@ -39,7 +39,6 @@ typedef struct CPUData_ {
    unsigned long long int idlePeriod;
 
    double frequency;
-   bool online;
 } CPUData;
 
 typedef struct NetBSDProcessList_ {

Should be done in the latest commit, also put a TODO reminder for this in the code.