Only add the parameters to the parameters map if they have a name#31
Merged
Nemo157 merged 1 commit intohttp-rs:masterfrom Aug 13, 2019
Merged
Only add the parameters to the parameters map if they have a name#31Nemo157 merged 1 commit intohttp-rs:masterfrom
Nemo157 merged 1 commit intohttp-rs:masterfrom
Conversation
gameldar
force-pushed
the
29-unnamed-parameters
branch
from
e6370b1 to
d51187c
Compare
Nemo157
force-pushed
the
29-unnamed-parameters
branch
from
d51187c to
b42a055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29 by only adding named parameters to the parameter map
Description
If the capture has an empty string for a name then don't add it to the map
Motivation and Context
Closes #29
Note this is technically a breaking change as before you could actually query for the parameter with an empty string.
How Has This Been Tested?
Unit tests have been implemented to ensure the intended behaviour
Types of changes
Checklist: