Rewind content at the end of Readable#to_s #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows calling #read after we've called #to_s.
|
Doesn’t it break calling |
|
Just realized that’s what your last paragraph is about. Can’t we check the current state to figure out should we rewind or not? |
Member
Author
We could theoretically track how many bytes we've read for each of the |
Member
|
I was thinking about the same that probably we could track current position and return to it after reading the whole body. But then I realized that it will both:
|
Member
|
@janko-m Thank you! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 17, 2018
## 2.1.0 (2018-03-05) * [#21](httprb/form_data#21) Rewind content at the end of `Readable#to_s`. [@janko-m][] * [#19](httprb/form_data#19) Fix buffer encoding. [@HoneyryderChuck][] ## 2.0.0 (2017-10-01) * [#17](httprb/form_data#17) Add CRLF character to end of multipart body. [@mhickman][] ## 2.0.0.pre2 (2017-05-11) * [#14](httprb/form_data#14) Enable streaming for urlencoded form data. [@janko-m][] ## 2.0.0.pre1 (2017-05-10) * [#12](httprb/form_data#12) Enable form data streaming. [@janko-m][]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows calling
#readafter we've called#to_s.This PR was motivated by httprb/http#437 (comment), where in httplog it was required to
#rewindthe form body after calling#to_son it (source). I just thought that this was surprising behaviour, and that there is no reason why not rewind the content after calling#to_son it.Btw, I think it makes sense to still keep the
#rewindbefore the#read, because httplog could one day decide they want to log the request data after the request has been made, at which point the form data objects would have been read. So then it would be nice to just be able to call#to_sand have it rewind the content automatically.