Add frozen_string_literal magic header

.rubocop.yml

@@ -55,6 +55,9 @@ Style/EachWithObject:
 Style/Encoding:
   Enabled: false
 
+Style/EmptyCaseCondition:
+  Enabled: false
+
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 

Gemfile

@@ -20,7 +20,7 @@ group :test do
   gem "coveralls"
   gem "simplecov", ">= 0.9"
   gem "json",      ">= 1.8.1"
-  gem "rubocop",   "=  0.39.0"
+  gem "rubocop",   "=  0.40.0"
   gem "rspec",     "~> 3.0"
   gem "rspec-its"
   gem "yardstick"

lib/http.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "http/parser"
 
 require "http/errors"

lib/http/content_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HTTP
   ContentType = Struct.new(:mime_type, :charset) do
     MIME_TYPE_RE = %r{^([^/]+/[^;]+)(?:$|;)}

lib/http/errors.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HTTP
   # Generic error
   class Error < StandardError; end

lib/http/headers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "forwardable"
 
 require "http/errors"

lib/http/headers/mixin.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "forwardable"
 
 module HTTP

lib/http/mime_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HTTP
   # MIME type encode/decode adapters
   module MimeType

lib/http/mime_type/adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "forwardable"
 require "singleton"
 

lib/http/mime_type/json.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "json"
 require "http/mime_type/adapter"
 

lib/http/options.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "http/headers"
 require "openssl"
 require "socket"

lib/http/redirector.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "set"
 
 require "http/headers"

lib/http/response.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "forwardable"
 
 require "http/headers"

lib/http/response/body.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "forwardable"
 require "http/client"
 
@@ -43,8 +44,9 @@ def to_s
         end
 
         begin
-          @streaming = false
-          @contents = "".force_encoding(encoding)
+          @streaming  = false
+          @contents   = String.new("").force_encoding(encoding)
+
           while (chunk = @client.readpartial)
             @contents << chunk.force_encoding(encoding)
           end

lib/http/response/parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HTTP
   class Response
     class Parser

lib/http/response/status.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "delegate"
 
 require "http/response/status/reasons"

lib/http/response/status/reasons.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # AUTO-GENERATED FILE, DO NOT CHANGE IT MANUALLY
 
 require "delegate"

lib/http/timeout/global.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "timeout"
 require "io/wait"
 

lib/http/timeout/null.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "forwardable"
 require "io/wait"
 

lib/http/timeout/per_operation.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "timeout"
 
 require "http/timeout/null"

spec/lib/http/client_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # coding: utf-8
 
 require "support/http_handling_shared"

spec/lib/http/content_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::ContentType do
   describe ".parse" do
     context "with text/plain" do

spec/lib/http/headers/mixin_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Headers::Mixin do
   let :dummy_class do
     Class.new do

spec/lib/http/headers_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Headers do
   subject(:headers) { described_class.new }
 

spec/lib/http/options/body_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options, "body" do
   let(:opts) { HTTP::Options.new }
 

spec/lib/http/options/form_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options, "form" do
   let(:opts) { HTTP::Options.new }
 

spec/lib/http/options/headers_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options, "headers" do
   let(:opts) { HTTP::Options.new }
 

spec/lib/http/options/json_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options, "json" do
   let(:opts) { HTTP::Options.new }
 

spec/lib/http/options/merge_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 RSpec.describe HTTP::Options, "merge" do
   let(:opts) { HTTP::Options.new }
@@ -23,7 +24,8 @@
       :body      => "body-foo",
       :json      => {:foo => "foo"},
       :headers   => {:accept => "json", :foo => "foo"},
-      :proxy     => {})
+      :proxy     => {}
+    )
 
     bar = HTTP::Options.new(
       :response   => :parsed_body,
@@ -36,27 +38,29 @@
       :headers            => {:accept => "xml", :bar => "bar"},
       :timeout_options    => {:foo => :bar},
       :ssl        => {:foo => "bar"},
-      :proxy      => {:proxy_address => "127.0.0.1", :proxy_port => 8080})
+      :proxy      => {:proxy_address => "127.0.0.1", :proxy_port => 8080}
+    )
 
     expect(foo.merge(bar).to_hash).to eq(
-      :response        => :parsed_body,
-      :timeout_class   => described_class.default_timeout_class,
-      :timeout_options => {:foo => :bar},
-      :params     => {:plop => "plip"},
-      :form       => {:bar => "bar"},
-      :body       => "body-bar",
-      :json       => {:bar => "bar"},
-      :persistent => "https://www.googe.com",
+      :response           => :parsed_body,
+      :timeout_class      => described_class.default_timeout_class,
+      :timeout_options    => {:foo => :bar},
+      :params             => {:plop => "plip"},
+      :form               => {:bar => "bar"},
+      :body               => "body-bar",
+      :json               => {:bar => "bar"},
+      :persistent         => "https://www.googe.com",
       :keep_alive_timeout => 10,
-      :ssl       => {:foo => "bar"},
-      :headers   => {"Foo" => "foo", "Accept" => "xml", "Bar" => "bar"},
-      :proxy     => {:proxy_address => "127.0.0.1", :proxy_port => 8080},
-      :follow => nil,
-      :socket_class     => described_class.default_socket_class,
-      :nodelay          => false,
-      :ssl_socket_class => described_class.default_ssl_socket_class,
-      :ssl_context      => nil,
-      :cookies          => {},
-      :encoding         => nil)
+      :ssl                => {:foo => "bar"},
+      :headers            => {"Foo" => "foo", "Accept" => "xml", "Bar" => "bar"},
+      :proxy              => {:proxy_address => "127.0.0.1", :proxy_port => 8080},
+      :follow             => nil,
+      :socket_class       => described_class.default_socket_class,
+      :nodelay            => false,
+      :ssl_socket_class   => described_class.default_ssl_socket_class,
+      :ssl_context        => nil,
+      :cookies            => {},
+      :encoding           => nil
+    )
   end
 end

spec/lib/http/options/new_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options, "new" do
   it "supports a Options instance" do
     opts = HTTP::Options.new

spec/lib/http/options/proxy_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options, "proxy" do
   let(:opts) { HTTP::Options.new }
 

spec/lib/http/options_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Options do
   subject { described_class.new(:response => :body) }
 

spec/lib/http/redirector_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Redirector do
   def simple_response(status, body = "", headers = {})
     HTTP::Response.new(

spec/lib/http/request/writer_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # coding: utf-8
 
 RSpec.describe HTTP::Request::Writer do

spec/lib/http/request_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # coding: utf-8
 
 RSpec.describe HTTP::Request do

spec/lib/http/response/body_spec.rb

@@ -1,17 +1,18 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Response::Body do
   let(:client)   { double(:sequence_id => 0) }
-  let(:chunks)   { ["Hello, ", "World!"] }
+  let(:chunks)   { [String.new("Hello, "), String.new("World!")] }
 
   before         { allow(client).to receive(:readpartial) { chunks.shift } }
 
-  subject(:body) { described_class.new client, Encoding::UTF_8 }
+  subject(:body) { described_class.new(client, Encoding::UTF_8) }
 
   it "streams bodies from responses" do
-    expect(subject.to_s).to eq "Hello, World!"
+    expect(subject.to_s).to eq("Hello, World!")
   end
 
   context "when body empty" do
-    let(:chunks) { [""] }
+    let(:chunks) { [String.new("")] }
 
     it "returns responds to empty? with true" do
       expect(subject).to be_empty

spec/lib/http/response/status_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Response::Status do
   describe ".new" do
     it "fails if given value does not respond to #to_i" do

spec/lib/http/response_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::Response do
   let(:body)          { "Hello world!" }
   let(:uri)           { "http://example.com/" }

spec/lib/http/uri_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe HTTP::URI do
   let(:example_http_uri_string)  { "http://example.com" }
   let(:example_https_uri_string) { "https://example.com" }

spec/lib/http_spec.rb

@@ -1,4 +1,5 @@
-# encoding: UTF-8
+# frozen_string_literal: true
+# encoding: utf-8
 
 require "json"
 

spec/regression_specs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 RSpec.describe "Regression testing" do

spec/spec_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # coding: utf-8
 
 require "simplecov"

spec/support/black_hole.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module BlackHole
   def self.method_missing(*)
     self

spec/support/capture_warning.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 def capture_warning
   old_stderr = $stderr
   $stderr = StringIO.new

spec/support/dummy_server.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "webrick"
 require "webrick/ssl"
 

spec/support/dummy_server/servlet.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # encoding: UTF-8
 
 class DummyServer < WEBrick::HTTPServer

spec/support/http_handling_shared.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.shared_context "HTTP handling" do
   describe "timeouts" do
     let(:conn_timeout) { 1 }

spec/support/proxy_server.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "webrick/httpproxy"
 
 require "support/black_hole"

spec/support/servers/config.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ServerConfig
   def addr
     config[:BindAddress]

spec/support/servers/runner.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ServerRunner
   def run_server(name)
     let! name do

spec/support/ssl_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "pathname"
 
 require "certificate_authority"