Skip to content

Bump llhttp-ffi (0.5.0)#744

Merged
tarcieri merged 1 commit intohttprb:mainfrom
bryanp:chg/update-llhttp-ffi-0.5.0
Mar 30, 2023
Merged

Bump llhttp-ffi (0.5.0)#744
tarcieri merged 1 commit intohttprb:mainfrom
bryanp:chg/update-llhttp-ffi-0.5.0

Conversation

@bryanp
Copy link
Copy Markdown
Contributor

@bryanp bryanp commented Mar 29, 2023

Updates the llhttp-ffi dependency to v0.5.0. The only difference is that it now uses lhttp v8.1.0, the latest release.

@bryanp
Copy link
Copy Markdown
Contributor Author

bryanp commented Mar 29, 2023

Note I am seeing one test failure on this branch but also see it in main:

1) HTTP::Options headers accepts any object that respond to :to_hash
     Failure/Error: x = Struct.new(:to_hash).new("accept" => "json")

     ArgumentError:
       unknown keywords: accept
     # ./spec/lib/http/options/headers_spec.rb:17:in `initialize'
     # ./spec/lib/http/options/headers_spec.rb:17:in `new'
     # ./spec/lib/http/options/headers_spec.rb:17:in `block (2 levels) in <top (required)>'

@tarcieri tarcieri merged commit ed8bd1f into httprb:main Mar 30, 2023
@bryanp bryanp deleted the chg/update-llhttp-ffi-0.5.0 branch March 30, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants