Drop depenency on base64 #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixti
reviewed
Feb 8, 2024
Earlopain
force-pushed
the
remove-base64-dep
branch
from
1bbb496 to
557a1bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Earlopain
force-pushed
the
remove-base64-dep
branch
from
557a1bc to
0fb18ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#759 added
base64as a depenency in order to suppress a warning/error on Ruby 3.3/3.4Since
base64is mostly just a wrapper around thepack/unpackmethods it's easy to just replace.Other gems have taken a similar approach:
base64gem from runtime dependency rubocop/rubocop#12313base64gem dependency socketry/protocol-http#51